Add validation for crate/package name in new/init#1943
Merged
Conversation
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
Agreed.
Makes sense. |
alonme
commented
Feb 24, 2024
| name, | ||
| ); | ||
| } | ||
| if is_windows_reserved(name) { |
Contributor
Author
There was a problem hiding this comment.
The original code bailed if the platform is actually windows, I think this should be good enough for now
Contributor
Author
|
@messense I believe this is ready for review 😄 |
Contributor
Author
|
@messense Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially solves #1398 (only cargo)
The current commit only adds a very basic validation as a POC before implementing the needed cargo / pypi checks
A few questions i have before finishing the implementation
The cargo validation seems to be comprised of 2 main parts,
a. Basic validation which is part of the crate cargo-util-schemas, and is not made public outside the crate
b. Extra validations that are public from the cargo package
I believe we should vendor these logics - one is private, and the other requires the cargo package which i believe will add many dependencies to the project
The
generate_projectfunction is de-facto defining a default value forGenerateProjectOptions.name- would it be better to move this logic intoGenerateProjectOptions?