Respect rustflags settings in cargo configuration file#1405
Merged
Respect rustflags settings in cargo configuration file#1405
rustflags settings in cargo configuration file#1405Conversation
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
0e1801c to
1409676
Compare
Member
Author
|
bors try |
Contributor
tryBuild succeeded: |
b6aad5b to
4217019
Compare
Member
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 11, 2023
1405: Respect `rustflags` settings in cargo configuration file r=messense a=messense https://github.com/taiki-e/cargo-config2 `CARGO_ENCODED_RUSTFLAGS` requires Rust 1.55+ so technically it's a breaking change even though our MSRV is 1.62 we can actually build packages with older versions of Rust. Co-authored-by: messense <messense@icloud.com>
4217019 to
4a5ad5b
Compare
Contributor
|
Canceled. |
4a5ad5b to
7871f68
Compare
https://doc.rust-lang.org/cargo/reference/config.html#buildrustflags There are four mutually exclusive sources of extra flags. They are checked in order, with the first one being used: 1. `CARGO_ENCODED_RUSTFLAGS` environment variable. 2. `RUSTFLAGS` environment variable. 3. All matching `target.<triple>.rustflags` and `target.<cfg>.rustflags` config entries joined together. 4. `build.rustflags` config value. This requires Rust 1.55+, our MSRV is 1.62 ATM so it's fine.
7871f68 to
bc631f1
Compare
Member
Author
|
bors retry |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/taiki-e/cargo-config2
CARGO_ENCODED_RUSTFLAGSrequires Rust 1.55+ so technically it's a breaking change even though our MSRV is 1.62 we can actually build packages with older versions of Rust.