Support SOURCE_DATE_EPOCH environment variable in wheel building#1334
Conversation
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
messense
reviewed
Dec 5, 2022
Member
messense
left a comment
There was a problem hiding this comment.
Thanks for the PR! Could you please fix the clippy warnings and add a changelog entry in Changelog.md?
This adds support for the `SOURCE_DATE_EPOCH` environment variable like wheel does when building wheels. If this environment variable is set, the `mtime` of the files in the wheel are set to this value to ensure reproducible output. Fixes #1320
Contributor
Author
This should be done now. |
Contributor
|
Build succeeded: |
Member
|
Released in v0.14.5. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Dec 13, 2022
https://build.opensuse.org/request/show/1042453 by user mia + dimstar_suse - Manually override outdated ahash dependency of chumsky crate in vendor tarball to hopefully facilitate reproducible builds Adds vendor-update-ahash-dependency.patch boo#1206342 - Update to v0.14.5: * Support SOURCE_DATE_EPOCH environment variable in wheel building gh#PyO3/maturin#1334 * Fix sdist when all Cargo workspace members are excluded gh#PyO3/maturin#1343 - Changes in v0.14.4: * Bump sigstore/gh-action-sigstore-python from 0.0.11 to 0.1.0 gh#PyO3/maturin#1317 * Refactor Target::get_platform_tag to use standard osname-release-machine fallback representation gh#PyO3/maturin#1318 * Better error message when upload failed with status code 403 gh#PyO3/maturin#1323 * Warn about patchelf version requirement gh#PyO3/maturin#1327 * Refactor compil
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 8, 2023
https://build.opensuse.org/request/show/1085456 by user mia + dimstar_suse - Update to v0.15.1: * Use shlex to split MATURIN_SETUP_ARGS gh#PyO3/maturin#1595 * Fix finding interpreters from bundled sysconfigs gh#PyO3/maturin#1598 - Changes in v0.15.0: * Feature gate zig and xwin based cross compiling gh#PyO3/maturin#1324 * Feature gate maturin new and maturin init commands gh#PyO3/maturin#1330 * Build with --no-default-features gh#PyO3/maturin#1333 * Support SOURCE_DATE_EPOCH environment variable in wheel building gh#PyO3/maturin#1334 * Remove deprecated config options gh#PyO3/maturin#1335 * cargo deny multiple crate versions gh#PyO3/maturin#1336 * Replace rpassword with dialoguer gh#PyO3/maturin#1338 * Fix sdist when all Cargo workspace members are excluded gh#PyO3/maturin#1343 * Update normpath to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the
SOURCE_DATE_EPOCHenvironment variable like wheel does when building wheels. If this environment variable is set, themtimeof the files in the wheel are set to this value to ensure reproducible output.Fixes #1320