Skip to content

Inherit labels from build#385

Merged
benjaminhuo merged 2 commits intoOpenFunction:mainfrom
oops-oom:main
Nov 13, 2022
Merged

Inherit labels from build#385
benjaminhuo merged 2 commits intoOpenFunction:mainfrom
oops-oom:main

Conversation

@oops-oom
Copy link
Contributor

No description provided.

@benjaminhuo
Copy link
Member

@oops-oom Thanks for the contribution
You need to sign your commit:

git commit -s --amend
git push

@benjaminhuo
Copy link
Member

@oops-oom You'll need to rebase the main branch:

git remote add upstream https://github.com/OpenFunction/OpenFunction.git
git fetch --all
git rebase upstream/main
git push -f

Signed-off-by: oops-oom <734819342@qq.com>
@benjaminhuo
Copy link
Member

@wanjunlei pls help to review this

@benjaminhuo
Copy link
Member

@wrongerror would you take a look at why the e2e timeout?

@wrongerror
Copy link
Member

@wrongerror would you take a look at why the e2e timeout?

I'll take a look at it later

@wrongerror
Copy link
Member

wrongerror commented Nov 12, 2022

reason:
Unsupported Kafka.spec.kafka.version: 3.1.0. Supported versions are: [3.2.0, 3.2.1, 3.2.3, 3.3.1]

how to fix:
bump kafka.version to 3.2.0+ https://github.com/OpenFunction/OpenFunction/blob/main/config/samples/function-kafka-quick.yaml#L8
@oops-oom would you fix this in this pr?

Signed-off-by: oops-oom <734819342@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants