postgresql: 12.18 -> 12.19, 13.14 -> 13.15, 14.11 -> 14.12, 15.6 -> 15.7, 16.2 -> 16.3, fix CVE-2024-4317 for 14+#310580
Merged
Ma27 merged 6 commits intoNixOS:stagingfrom May 12, 2024
Merged
Conversation
Member
Author
|
Note: nominatim is still building, would like to see if it just works with latest postgresql. Otherwise I'd mark it as broken. SGTM. cc @mausch |
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
May 10, 2024
…5.7, 16.2 -> 16.3, fix CVE-2024-4317 Announcement: Announcement: https://www.postgresql.org/about/news/postgresql-163-157-1412-1315-and-1219-released-2858/ Backport of NixOS#310580
13 tasks
Contributor
|
There is this piece in # TODO: Remove after the next set of minor releases on May 9th 2024
preCheck =
# On musl, comment skip the following tests, because they break due to
# ! ERROR: could not load library "/build/postgresql-11.5/tmp_install/nix/store/...-postgresql-11.5-lib/lib/libpqwalreceiver.so": Error loading shared library libpq.so.5: No such file or directory (needed by /build/postgresql-11.5/tmp_install/nix/store/...-postgresql-11.5-lib/lib/libpqwalreceiver.so)
# See also here:
# https://git.alpinelinux.org/aports/tree/main/postgresql/disable-broken-tests.patch?id=6d7d32c12e073a57a9e5946e55f4c1fbb68bd442
if stdenv'.hostPlatform.isMusl then ''
substituteInPlace src/test/regress/parallel_schedule \
--replace "subscription" "" \
--replace "object_address" ""
'' else null;This can be removed entirely. We better double check whether |
Member
Author
|
Updated, v12 is part of the PR now. |
Contributor
|
The other comment above still applies: #310580 (comment) I added that TODO do remove the test exceptions with the next minor release, so we should do that now. |
Member
Author
|
Pushed a fix, currently running a pkgsMusl build just to be sure. EDIT: looks good. |
Contributor
@Ma27 Did you actually push? I can't see the changes in the PR. |
Member
Author
|
Now I did, apologies! |
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Jun 14, 2024
This was discussed and agreed on in [1]. [1]: NixOS#310580 (comment)
wegank
pushed a commit
to RaitoBezarius/nixpkgs
that referenced
this pull request
Jun 20, 2024
This was discussed and agreed on in [1]. [1]: NixOS#310580 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Announcement: https://www.postgresql.org/about/news/postgresql-163-157-1412-1315-and-1219-released-2858/
cc @wolfgangwalther @ajs124 @mweinelt
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.