Open
Conversation
lvhan028
reviewed
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reusable helper module and introduces comprehensive RESTful API tests for tool-calling and reasoning behavior across supported backends/models, while extending the model lists used to parametrize these tests.
Changes:
- Added
autotest/utils/tool_reasoning_definitions.pyto share tool schemas, logging helpers, and stream aggregation utilities between test suites. - Added new RESTful test suites for tool calls (
test_restful_tool_calls.py) and reasoning (test_restful_reasoning.py), including parser unit tests and API-level streaming/non-streaming checks. - Extended constants with a dedicated
TOOL_REASONING_MODEL_LISTand reformattedRESTFUL_MODEL_LISTfor readability.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| autotest/utils/tool_reasoning_definitions.py | Centralizes shared tool/reasoning test utilities (schemas, logging, stream collectors). |
| autotest/utils/constant.py | Adds TOOL_REASONING_MODEL_LIST and reformats RESTFUL_MODEL_LIST. |
| autotest/interface/restful/test_restful_tool_calls.py | Introduces extensive REST API tests validating tool-call behavior (streaming/non-streaming, tool_choice, parallel calls). |
| autotest/interface/restful/test_restful_reasoning.py | Adds reasoning API tests plus unit tests for reasoning parsers and token accounting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lvhan028
reviewed
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist