fix logical interconnect group issues#544
Open
adarobin wants to merge 2 commits intoHewlettPackard:masterfrom
Open
fix logical interconnect group issues#544adarobin wants to merge 2 commits intoHewlettPackard:masterfrom
adarobin wants to merge 2 commits intoHewlettPackard:masterfrom
Conversation
Signed-off-by: Adam Robinson <adarobin@umich.edu>
Signed-off-by: Adam Robinson <adarobin@umich.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The crashes I have experienced with
oneview_logical_interconnect_grouphave been resolved, but I have still had some issues with the resource complaining about attributes being set that are read only or have default values defined and showing a change when there isn't any. There were also several attributes that were not being set on a read.This also fixes the resource to read in uplink_set when doing an import. I haven't figured out a way to handle the ordering of uplink_set when doing an import though. The ideal solution would probably be for uplink_set to be TypeSet, but I'm not sure how feasible that is.
Issues Resolved
Check List