feat: updating Tensorboard related code to use v1#851
feat: updating Tensorboard related code to use v1#851yfang1 merged 1 commit intogoogleapis:mainfrom yfang1:v1
Conversation
google/cloud/aiplatform/tensorboard/plugins/tf_profiler/profile_uploader.py
Outdated
Show resolved
Hide resolved
|
Left a comment which applies to all the changes. So the rule of thumb is: if your expected version aligns with the |
morgandu
left a comment
There was a problem hiding this comment.
Sorry I probably missed the test_uploader.py in the previous review. For unit tests, we don't rely on the compat module, instead we specify the expected version. Because we don't have tests when compat may or may not select different version within different resource class methods, this way we can ensure class methods calling compat returning the right version we expect.
We only discussed this when compat was introduced, but did not enforce the implementation across all other module, so there is some inconsistency in the code base. But prefer start to enforce it for the reason mentioned above.
Fallout of #849