refactor: Use object.prototype to check for reserved properties#5670
Merged
lukastaegert merged 1 commit intorollup:masterfrom Sep 21, 2024
Merged
refactor: Use object.prototype to check for reserved properties#5670lukastaegert merged 1 commit intorollup:masterfrom
lukastaegert merged 1 commit intorollup:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5670 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 242 242
Lines 9346 9348 +2
Branches 2470 2472 +2
=======================================
+ Hits 9289 9291 +2
Misses 48 48
Partials 9 9 ☔ View full report in Codecov by Sentry. |
lukastaegert
approved these changes
Sep 21, 2024
|
This PR has been released as part of rollup@4.22.4. You can test it via |
JSRAInmob
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description:
This PR includes the following improvements:
Refactoring the use of the
inoperator: Replaced the use of theinoperator on an empty object{}withObject.prototypeto properly check ifparts[0]is a property of JavaScript's built-in objects. The previous approach always returnedfalse, making the check ineffective.Optimization of null assignment logic: When
isReservedistrue, assigningnulltoparts[0]was unnecessary. Instead,parts[0]is now retained to avoid redundant null assignments and improve the overall logic.