Partially revert #5658 and re-apply #5644#5667
Merged
lukastaegert merged 1 commit intomasterfrom Sep 20, 2024
Merged
Conversation
It appears that this might cause some build failures that need further investigation.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#revertNotice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report!Rough benchmark
Internal benchmark
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5667 +/- ##
==========================================
- Coverage 99.39% 99.39% -0.01%
==========================================
Files 242 242
Lines 9348 9346 -2
Branches 2470 2470
==========================================
- Hits 9291 9289 -2
Misses 48 48
Partials 9 9 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.22.2. You can test it via |
This was referenced Oct 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that this might cause some build failures that need further investigation.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
moduleSideEffects: falseremoves side effectful getter inside a exported function since 4.9.2 #5408Description
Apparently, the previous change caused bigger issues that need investigation.