fix: applying a new config to useGesture / Gesture shouldn't throw an error (#542)

dbismut · web-flow · commit de807fddc5d4 · 2022-09-15T21:51:50.000+02:00
diff --git a/.changeset/dirty-planets-protect.md b/.changeset/dirty-planets-protect.md
@@ -0,0 +1,5 @@
+---
+'@use-gesture/core': patch
+---
+
+fix: applying a new config to useGesture / Gesture shouldn't throw an error.
diff --git a/packages/core/src/Controller.ts b/packages/core/src/Controller.ts
@@ -66,7 +66,7 @@ export class Controller {
    * @param gestureKey
    */
   applyConfig(config: UserGestureConfig, gestureKey?: GestureKey) {
-    this.config = parse(config, gestureKey)
+    this.config = parse(config, gestureKey, this.config)
   }
   /**
    * Cleans all side effects (listeners, timeouts). When the gesture is
diff --git a/packages/core/src/config/resolver.ts b/packages/core/src/config/resolver.ts
@@ -34,12 +34,10 @@ export function resolveWith<T extends { [k: string]: any }, V extends { [k: stri
   return result
 }
 
-export function parse(config: UserGestureConfig, gestureKey?: GestureKey): InternalConfig {
-  const { target, eventOptions, window, enabled, transform, ...rest } = config as any
+export function parse(newConfig: UserGestureConfig, gestureKey?: GestureKey, _config: any = {}): InternalConfig {
+  const { target, eventOptions, window, enabled, transform, ...rest } = newConfig as any
 
-  const _config: any = {
-    shared: resolveWith({ target, eventOptions, window, enabled, transform }, sharedConfigResolver)
-  }
+  _config.shared = resolveWith({ target, eventOptions, window, enabled, transform }, sharedConfigResolver)
 
   if (gestureKey) {
     const resolver = ConfigResolverMap.get(gestureKey)!

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@use-gesture/core': patch
 +---
++
 +fix: applying a new config to useGesture / Gesture shouldn't throw an error.
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ export class Controller {`
`66`	`66`	`* @param gestureKey`
`67`	`67`	`*/`
`68`	`68`	`applyConfig(config: UserGestureConfig, gestureKey?: GestureKey) {`
`69`		`- this.config = parse(config, gestureKey)`
	`69`	`+ this.config = parse(config, gestureKey, this.config)`
`70`	`70`	`}`
`71`	`71`	`/**`
`72`	`72`	`* Cleans all side effects (listeners, timeouts). When the gesture is`