Refactor metrics to remove MeterSharedState#6845
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Nov 5, 2024
Merged
Refactor metrics to remove MeterSharedState#6845jack-berg merged 1 commit intoopen-telemetry:mainfrom
jack-berg merged 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6845 +/- ##
============================================
- Coverage 90.49% 90.47% -0.02%
+ Complexity 6599 6588 -11
============================================
Files 731 729 -2
Lines 19738 19724 -14
Branches 1938 1941 +3
============================================
- Hits 17862 17846 -16
- Misses 1285 1286 +1
- Partials 591 592 +1 ☔ View full report in Codecov by Sentry. |
Contributor
|
I believe this was a holdover from OC metrics, where (IIRC), you could have more than one meter instance that shared the same state. If we don't need it any more, then 🥂 ! |
trask
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm starting to think about how to allow for updating SDK configuration. Starting with metrics because traces and logs are a cake walk in comparison. While doing some analysis I realized that MeterSharedState is a silly concept - all of its logic and state can just be held directly on the respective SdkMeter.
This reduces complexity and makes it easier to reason over.