fix: undo CRLF on Windows (talosctl edit)

smira · shanduur · commit 4a3385dfbdba · 2026-02-06T09:28:58.000+01:00
Fixes #12664 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit 410d8cb)
diff --git a/cmd/talosctl/cmd/talos/edit.go b/cmd/talosctl/cmd/talos/edit.go
@@ -156,6 +156,13 @@ func editFn(c *client.Client) func(context.Context, string, resource.Resource, e
 }
 
 func stripEditingComment(in []byte) []byte {
+	// Note: on Windows, we use crlf.NewCRLFWriter which converts LF to CRLF before opening the editor.
+	// So this code block below undoes that conversion back to LF for consistent processing.
+	if runtime.GOOS == "windows" {
+		// revert back CRLF to LF for processing
+		in = bytes.ReplaceAll(in, []byte("\r\n"), []byte("\n"))
+	}
+
 	for {
 		idx := bytes.Index(in, []byte{'\n'})
 		if idx == -1 {
