Improve test coverage for attribution_control.ts (#7120)

pierreeurope · web-flow · commit b1109559fd29 · 2026-02-19T08:24:44.000+02:00
* Improve test coverage for attribution_control.ts

Added comprehensive edge case tests:
- Filtering non-string values from customAttribution array
- Filtering whitespace-only attributions from sources
- Testing _updateCompactMinimize behavior during map drag events
- Verifying onRemove properly cleans up event listeners and state
- Handling empty customAttribution strings
- Deduplication of identical attributions from multiple sources

These tests improve robustness and ensure edge cases are handled correctly.

* test: remove redundant comments and split compact-show test

Signed-off-by: pierreeurope &lt;pierre.europe@pm.me&gt;

* Address review: use DOM queries instead of internal fields, split compact test

* Revert unrelated CSS changes

---------

Signed-off-by: pierreeurope &lt;pierre.europe@pm.me&gt;
diff --git a/src/ui/control/attribution_control.test.ts b/src/ui/control/attribution_control.test.ts
@@ -566,4 +566,79 @@ describe('AttributionControl test regarding the HTML elements details and summar
             expect(map.getContainer().querySelectorAll('.maplibregl-ctrl-attrib')[0].getAttribute('open')).toBe('');
         });
     });
+
+    describe('edge cases', () => {
+        test('whitespace-only source attribution is filtered out', async () => {
+            const attribution = new AttributionControl({});
+            map.addControl(attribution);
+            await map.once('load');
+
+            map.addSource('whitespace', {
+                type: 'geojson',
+                data: {type: 'FeatureCollection', features: []},
+                attribution: ' '
+            });
+            map.addSource('valid', {
+                type: 'geojson',
+                data: {type: 'FeatureCollection', features: []},
+                attribution: 'Valid Attribution'
+            });
+
+            map.addLayer({id: 'whitespace', type: 'fill', source: 'whitespace'});
+            map.addLayer({id: 'valid', type: 'fill', source: 'valid'});
+
+            await sleep(100);
+
+            const innerContainer = map.getContainer().querySelector('.maplibregl-ctrl-attrib-inner');
+            expect(innerContainer.innerHTML).toBe('Valid Attribution');
+        });
+
+        test('empty customAttribution string results in empty attribution', () => {
+            map.addControl(new AttributionControl({customAttribution: ''}));
+
+            const container = map.getContainer();
+            const attrib = container.querySelector('.maplibregl-ctrl-attrib-inner');
+            expect(attrib.innerHTML).toBe('');
+            expect(container.querySelectorAll('.maplibregl-attrib-empty')).toHaveLength(1);
+        });
+
+        test('compact attribution is initially expanded', () => {
+            Object.defineProperty(map.getCanvasContainer(), 'offsetWidth', {value: 600, configurable: true});
+            map.addControl(new AttributionControl({
+                compact: true,
+                customAttribution: 'Test Attribution'
+            }));
+
+            expect(map.getContainer().querySelectorAll('.maplibregl-compact-show')).toHaveLength(1);
+        });
+
+        test('drag minimizes expanded compact attribution', () => {
+            Object.defineProperty(map.getCanvasContainer(), 'offsetWidth', {value: 600, configurable: true});
+            map.addControl(new AttributionControl({
+                compact: true,
+                customAttribution: 'Test Attribution'
+            }));
+
+            const container = map.getContainer();
+            const toggle = container.querySelector('.maplibregl-ctrl-attrib-button');
+            simulate.click(toggle);
+            simulate.click(toggle);
+            expect(container.querySelectorAll('.maplibregl-compact-show')).toHaveLength(1);
+
+            map.fire('drag');
+            expect(container.querySelectorAll('.maplibregl-compact-show')).toHaveLength(0);
+        });
+
+        test('onRemove cleans up DOM', () => {
+            const attribution = new AttributionControl({customAttribution: 'Test', compact: true});
+            map.addControl(attribution);
+
+            const container = map.getContainer();
+            expect(container.querySelectorAll('.maplibregl-ctrl-attrib')).toHaveLength(1);
+
+            map.removeControl(attribution);
+
+            expect(container.querySelectorAll('.maplibregl-ctrl-attrib')).toHaveLength(0);
+        });
+    });
 });
