fix(deps): add detector-resource-support dependencies#2559
fix(deps): add detector-resource-support dependencies#2559diegomarquezp merged 6 commits intogoogleapis:mainfrom
Conversation
| <dependency> | ||
| <groupId>io.opentelemetry</groupId> | ||
| <artifactId>opentelemetry-api</artifactId> | ||
| <artifactId>opentelemetry-bom</artifactId> |
There was a problem hiding this comment.
Perfect! Yes! I do also need the other detector-resources-support dependency though. Do you think you can also add that in your PR?
There was a problem hiding this comment.
Since we don't use detector-resources-support, I think it's better to leave it in this PR. I'll let you know once we merged our Otel PR.
There was a problem hiding this comment.
@mutianf The PR is merged now, do you mind modifying this PR accordingly?
There was a problem hiding this comment.
Updated! However I noticed that the open telemetry version in shared-dependencies pom is already 1.36.0 but in gax it was still 1.35.0. I think we should update the version in gax :)
There was a problem hiding this comment.
The OpenTelemetry version in Gax should come from the same opentelemetry.version property, where did you find that it is still 1.35.0? In addition, I think we might be able to remove opentelemetry-bom section from this pom because it is already declared in Gax?
|
/gcbrun |
|
|
🤖 I have created a release *beep* *boop* --- <details><summary>2.38.1</summary> ## [2.38.1](v2.38.0...v2.38.1) (2024-03-15) ### Bug Fixes * **deps:** add detector-resource-support dependencies ([#2559](#2559)) ([53f2c85](53f2c85)) * Update shopping and chat common protos. ([#2580](#2580)) ([f472756](f472756)) ### Dependencies * update google api dependencies ([#2582](#2582)) ([dd03d93](dd03d93)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Blake Li <blakeli@google.com>
b/329410901