-
Notifications
You must be signed in to change notification settings - Fork 75
Open
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.
Description
To help catch javadoc errors upstream, implement a downstream check on the generator similar to this one: googleapis/java-shared-config#662 that checks javadoc generation on a couple of libraries to ensure javadoc generation works.
In terms of what the javadoc generation should test for:
-
The current cloud RAD generation uses Java11 with this doclet: https://github.com/googleapis/java-docfx-doclet/tree/main/third_party.
-
In general, to account for self-service clients, the plain
mvn javadoc:aggregatecommand should also pass. This should be checked on Java 17, and possibly Java 11 as well. If we migrate the cloud RAD generation to use Java17, then I think we don't need to check for Java11 anymore, but that will be a separate project.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.