Skip to content

google/cloud/location/locations.proto should not be added to the proto files when generating from google/privacy/dlp/v2 #1999

@JoeWang1127

Description

@JoeWang1127

Compare the generating result between bazel build and generate_library.sh, google/cloud/location/locations.proto should not be generated even though name: '*google.cloud.location.Locations'* is found in dlp_v2.yaml.

The protoc command in bazel build is (omit unrelevent contents):

protoc --experimental_allow_proto3_optional --plugin=protoc-gen-java_gapic=protoc-gen-java_gapic --java_gapic_out=metadata:dlp_java_gapic_srcjar_raw.srcjar.zip --java_gapic_opt=transport=grpc+rest,rest-numeric-enums,grpc-service-config=google/privacy/dlp/v2/dlp_grpc_service_config.json,gapic-config=google/privacy/dlp/v2/dlp_gapic.yaml,api-service-config=google/privacy/dlp/v2/dlp_v2.yaml google/privacy/dlp/v2/dlp.proto google/privacy/dlp/v2/storage.proto google/cloud/common_resources.proto

The protoc command in generate_library.sh is:

protoc --experimental_allow_proto3_optional --plugin=protoc-gen-java_gapic=gapic-generator-java-wrapper --java_gapic_out=metadata:java_gapic_srcjar_raw.srcjar.zip --java_gapic_opt=transport=grpc+rest,rest-numeric-enums,grpc-service-config=google/privacy/dlp/v2/dlp_grpc_service_config.json,gapic-config=google/privacy/dlp/v2/dlp_gapic.yaml,api-service-config=google/privacy/dlp/v2/dlp_v2.yaml google/privacy/dlp/v2/dlp.proto google/privacy/dlp/v2/storage.proto google/cloud/common_resources.proto google/cloud/location/locations.proto

Remove google/cloud/location/locations.proto in the protoc command can generate the right result.

Metadata

Metadata

Assignees

Labels

hermetic-buildpriority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions