perf: Remove redundant entity key serialization in online_read

abhijeet-dhumal · ntkathole · commit d87283fa7d64 · 2026-03-02T16:23:02.000+05:30
Signed-off-by: abhijeet-dhumal &lt;abhijeetdhumal652@gmail.com&gt;
diff --git a/sdk/python/feast/infra/online_stores/snowflake.py b/sdk/python/feast/infra/online_stores/snowflake.py
@@ -1,4 +1,3 @@
-import itertools
 import os
 from binascii import hexlify
 from datetime import datetime
@@ -168,20 +167,26 @@ def online_read(
 
         requested_features = requested_features if requested_features else []
 
+        # Pre-compute serialized entity keys to avoid redundant serialization
+        serialized_entity_keys = [
+            serialize_entity_key(
+                entity_key,
+                entity_key_serialization_version=config.entity_key_serialization_version,
+            )
+            for entity_key in entity_keys
+        ]
+
         entity_fetch_str = ",".join(
             [
                 (
                     "TO_BINARY("
                     + hexlify(
-                        serialize_entity_key(
-                            combo[0],
-                            entity_key_serialization_version=config.entity_key_serialization_version,
-                        )
-                        + bytes(combo[1], encoding="utf-8")
+                        serialized_entity_key + bytes(feature, encoding="utf-8")
                     ).__str__()[1:]
                     + ")"
                 )
-                for combo in itertools.product(entity_keys, requested_features)
+                for serialized_entity_key in serialized_entity_keys
+                for feature in requested_features
             ]
         )
 
@@ -197,11 +202,7 @@ def online_read(
             """
             df = execute_snowflake_statement(conn, query).fetch_pandas_all()
 
-        for entity_key in entity_keys:
-            entity_key_bin = serialize_entity_key(
-                entity_key,
-                entity_key_serialization_version=config.entity_key_serialization_version,
-            )
+        for entity_key_bin in serialized_entity_keys:
             res = {}
             res_ts = None
             for index, row in df[df["entity_key"] == entity_key_bin].iterrows():
diff --git a/sdk/python/feast/infra/online_stores/sqlite.py b/sdk/python/feast/infra/online_stores/sqlite.py
@@ -263,11 +263,7 @@ def online_read(
         rows = {
             k: list(group) for k, group in itertools.groupby(rows, key=lambda r: r[0])
         }
-        for entity_key in entity_keys:
-            entity_key_bin = serialize_entity_key(
-                entity_key,
-                entity_key_serialization_version=config.entity_key_serialization_version,
-            )
+        for entity_key_bin in serialized_entity_keys:
             res = {}
             res_ts = None
             for _, feature_name, val_bin, ts in rows.get(entity_key_bin, []):
