-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Comparing changes
Open a pull request
base repository: facebook/react-native
base: v0.79.0-rc.2
head repository: facebook/react-native
compare: v0.79.0
- 18 commits
- 53 files changed
- 7 contributors
Commits on Mar 18, 2025
-
Configuration menu - View commit details
-
Copy full SHA for fb7ca6a - Browse repository at this point
Copy the full SHA fb7ca6aView commit details -
marked acquireWakeLockNow as static as it was static before (#49875)
Summary: acquireWakeLockNow was static before but wasn't marked as static in 9afad52 when changing code to Kotlin. This breaks react-native-firebase but I've submitted the bug report there as I guess it might be fixed there too. ## Changelog: [ANDROID] [FIXED] - Marked acquireWakeLockNow as static Pull Request resolved: #49875 Test Plan: No tests as it reverts the broken change Reviewed By: rshest Differential Revision: D70773675 Pulled By: javache fbshipit-source-id: d7363702dfec078b7e6d2693d05b8ab87e818522
Configuration menu - View commit details
-
Copy full SHA for 6699563 - Browse repository at this point
Copy the full SHA 6699563View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9498b71 - Browse repository at this point
Copy the full SHA 9498b71View commit details
Commits on Mar 19, 2025
-
Handle null params in the Interop TM layer (#49873)
Summary: Pull Request resolved: #49873 In the old architecture, when we were passing a `null` value as a parameter in a function that accepted nullable parameter, the null value was mapped to `nil` on iOS. After my changes in [d423679](d423679), in the New Architecture, through the interop layer, legacy modules were receiving an `NSNull` object instead of nil. This was breaking those modules which started crashing or observing undesired behavior. This change fixes the issue by making sure that, in those cases, a `nil` value is passed. Note that nested objects in the old architecture were correctly receiving NSNull, so nested objects were behaving correctly already. ## Changelog: [iOS][Fixed] - Properly pass `nil` for nullable parameters instead of `NSNull` for legacy modules Reviewed By: javache Differential Revision: D70723460 fbshipit-source-id: 384f48b6dbb3f54c369b31b6d2ee06069fa3591c
Configuration menu - View commit details
-
Copy full SHA for 6314925 - Browse repository at this point
Copy the full SHA 6314925View commit details
Commits on Mar 21, 2025
-
Add React-renderercss dependency for 3p libs (#50192)
Summary: Pull Request resolved: #50192 Third party libraries depend transitively agains the React-renderercss modules because it is imported by Fabric. Without this change, the use_frameworks on iOS does not works when a 3P library is imported. This changes fix the behavior and we need to cherry pick them in 0.79. ## Changelog: [iOS][Fixed] - Make sure 3p libraries depends on React-renderercss to work with use_frameworks Reviewed By: fabriziocucci Differential Revision: D71618395 fbshipit-source-id: 70c12dcbeb2dfa5fd7513c27d5c069a1f3c95966
Configuration menu - View commit details
-
Copy full SHA for 5d26c51 - Browse repository at this point
Copy the full SHA 5d26c51View commit details
Commits on Mar 24, 2025
-
Convert to JSException only NSException from sync methods (#50193)
Summary: Pull Request resolved: #50193 This fix makes sure that we convert to JSException only NSException thrwn by sync methods. Currently, nothing in the stack will be capable of understanding that js error if it is triggered by an exception raised by an asyc method. See reactwg/react-native-new-architecture#276 for further details We need to cherry pick this in 0.78 and 0.79 ## Changelog: [iOS][Fixed] - Make sure the TM infra does not crash on NSException when triggered by async method Reviewed By: fabriziocucci Differential Revision: D71619229 fbshipit-source-id: b87aef5dd2720a2641c8da0904da651866370dc6
Configuration menu - View commit details
-
Copy full SHA for 9805a4f - Browse repository at this point
Copy the full SHA 9805a4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63fdc04 - Browse repository at this point
Copy the full SHA 63fdc04View commit details -
Configuration menu - View commit details
-
Copy full SHA for abad2f4 - Browse repository at this point
Copy the full SHA abad2f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f838c2 - Browse repository at this point
Copy the full SHA 4f838c2View commit details
Commits on Mar 26, 2025
-
Correctly batch reportMount calls (#50090)
Summary: Pull Request resolved: #50090 Changelog: [internal] I refactored `FabricUIManager` in D54547194 / #43337 and accidentally removed setting this flag to avoid scheduling redundant tasks in the UI thread to report mount. This fixes it. Reviewed By: javache Differential Revision: D71387374 fbshipit-source-id: cad8a3ead2434738325560902cbab817e5d5dde7
Configuration menu - View commit details
-
Copy full SHA for 4e4b9ba - Browse repository at this point
Copy the full SHA 4e4b9baView commit details -
Avoid errors when dispatching mount operations within mount hooks (#5…
…0091) Summary: Pull Request resolved: #50091 Changelog: [internal] If a library uses mount hooks to perform mount operations, it's possible to get concurrent modifications of the list of pending surface IDs to report. This fixes that potential error by making a copy of the list before dispatching the mount notifications. Fixes #49783. Reviewed By: javache Differential Revision: D71387739 fbshipit-source-id: 96c723ef2d6bcc659c4452434b7a4d5af26117ef
Configuration menu - View commit details
-
Copy full SHA for a42971a - Browse repository at this point
Copy the full SHA a42971aView commit details
Commits on Mar 27, 2025
-
Have react-hermes and React-renderercss define modules (#50283)
Summary: Pull Request resolved: #50283 In OSS we have some libraries written in Swift, like Flashlist, that depends on these pods. However, if a pod is not configured to define modules, those pods cannot be imported by Swift. Therefore, the libraries above will failed to be installed in a project. This change adds the defines_modules directive to those pods and make the library work again. This fixes #50246 [Internal] - Make React-hermes and React-renderercss defines modules Reviewed By: fabriziocucci Differential Revision: D71892679 fbshipit-source-id: b03b65986fbdbe781b616f31dfb6bceb38b8b3b7
Configuration menu - View commit details
-
Copy full SHA for adb3bee - Browse repository at this point
Copy the full SHA adb3beeView commit details
Commits on Mar 28, 2025
-
Back out "fix: avoid race condition crash in [RCTDataRequestHandler i…
…nvalidate]" (#49797) Summary: Pull Request resolved: #49797 Backing D70314889 as it was breaking some internal tests. I verified that before the backout the tests were failing and after the backout they were not. ## Changelog: [iOS][Changed] - Reverted fix: avoid race condition crash in [RCTDataRequestHandler invalidate]. Reviewed By: Abbondanzo Differential Revision: D70511155 fbshipit-source-id: 276f6947aa6bb648c9c9eeb5c342f336acc8a26f
Configuration menu - View commit details
-
Copy full SHA for 0bd7b4e - Browse repository at this point
Copy the full SHA 0bd7b4eView commit details -
fix React-jsitooling build error for use_frameworks build (#50252)
Summary: to resolve use_frameworks build error. this is an edge case happening only when there's objective-c files import to `React_RCTAppDelegate`. Xcode will have `include of non-modular header inside framework module` error originally. this is the generated umbrella header for jsitooling is incorrect. even the header path are correct, they are not modular headers. ~this pr adds a workaround to import header from outside the module.~ updates: this pr uses a forward declaration to prevent exposing the dependency in umbrella header. [IOS] [FIXED] - `JSRuntimeFactoryCAPI.h` build error for `use_frameworks` build Pull Request resolved: #50252 Test Plan: to reproduce the build error, we can build `USE_FRAMEWORKS=static bundle exec pod install` from rn-tester. we also need to import `React_RCTAppDelegate` from objective-c files. in this case, we can add `import React_RCTAppDelegate;` in rn-tester's main.m ```diff --- a/packages/rn-tester/RNTester/main.m +++ b/packages/rn-tester/RNTester/main.m @@ -8,6 +8,9 @@ #import <UIKit/UIKit.h> #import "AppDelegate.h" +@import React_RCTAppDelegate; +// This also triggers the error +//#import <React_RCTAppDelegate/React-RCTAppDelegate-umbrella.h> int main(int argc, char *argv[]) { ``` Reviewed By: fabriziocucci Differential Revision: D71963188 Pulled By: cipolleschi fbshipit-source-id: 5d566ae5aadb9efc032aacfe32862ea289134f87
Configuration menu - View commit details
-
Copy full SHA for 6c907ee - Browse repository at this point
Copy the full SHA 6c907eeView commit details
Commits on Mar 31, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 0df2a11 - Browse repository at this point
Copy the full SHA 0df2a11View commit details
Commits on Apr 1, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 2abcf99 - Browse repository at this point
Copy the full SHA 2abcf99View commit details
Commits on Apr 3, 2025
-
Pin cmake version to 3.31.6 (#50464)
Summary: Pull Request resolved: #50464 Runners in GHA has been updated by github and they now ship with CMake 4.0. (actions/runner-images#11926) This version is not compatible with React Native, so we are pinning cmake to 3.36.1 ## Changelog: [Internal] - Pin cmake to 3.36.1 Reviewed By: cortinico Differential Revision: D72379834 fbshipit-source-id: ab09009102118e6590f02cf57fa6f9149482f62b
Configuration menu - View commit details
-
Copy full SHA for e0012c0 - Browse repository at this point
Copy the full SHA e0012c0View commit details
Commits on Apr 8, 2025
-
Configuration menu - View commit details
-
Copy full SHA for c823a14 - Browse repository at this point
Copy the full SHA c823a14View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.79.0-rc.2...v0.79.0