-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Comparing changes
Open a pull request
base repository: facebook/react-native
base: v0.77.0-rc.4
head repository: facebook/react-native
compare: v0.77.0
- 20 commits
- 46 files changed
- 11 contributors
Commits on Dec 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5b8ed37 - Browse repository at this point
Copy the full SHA 5b8ed37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 489b22c - Browse repository at this point
Copy the full SHA 489b22cView commit details
Commits on Dec 30, 2024
-
fix: do not overwrite external
inputAccessoryViewon Fabric (#48339)Summary: If 3rd party libs are using `inputAccessoryView` - the current code can easily break it. Whenever props gets changed we call `setDefaultInputAccessoryView` which will simply overwrite the current `inputAccessoryView` (which is highly undesirable). The same fix on paper was made ~7 years ago: bf36983 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [FIXED] - Fixed problem with accessory view & 3rd party libs For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #48339 Test Plan: Make sure `inputAccessoryView` functionality works as before Reviewed By: javache Differential Revision: D67451188 Pulled By: cipolleschi fbshipit-source-id: bc3fa82ae15f8acedfd0b4e17bdea69cbd8c8a8d
Configuration menu - View commit details
-
Copy full SHA for d34032b - Browse repository at this point
Copy the full SHA d34032bView commit details -
Fabric: Fixes Numeric TextInput not triggering onSubmitEditing (#48276)
Summary: Fixes #48259 . The paper code like : https://github.com/facebook/react-native/blob/2fee13094b3d384c071978776fd8b7cff0b6530f/packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputView.mm#L777-L784 ## Changelog: [IOS] [FIXED] - Fabric: Fixes Numeric TextInput not triggering onSubmitEditing Pull Request resolved: #48276 Test Plan: Repro in #48259 Reviewed By: cipolleschi Differential Revision: D67274739 Pulled By: javache fbshipit-source-id: 57396c6e1a8ef96a1b29cae4a9aa9b5f48f6080b
Configuration menu - View commit details
-
Copy full SHA for 0bcb0c2 - Browse repository at this point
Copy the full SHA 0bcb0c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d472ae - Browse repository at this point
Copy the full SHA 9d472aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb9d7ad - Browse repository at this point
Copy the full SHA bb9d7adView commit details
Commits on Dec 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 17a5d2b - Browse repository at this point
Copy the full SHA 17a5d2bView commit details
Commits on Jan 6, 2025
-
fix: Prioritise local cpp (use default as fallback) (#48340)
Summary: #47379 removed local cpp sources from the sources being built with the app. This resulted in a local `android/app/src/main/jni/OnLoad.cpp` file being ignored at build time. I have therefore added logic to the cmake file to prioritise local `cpp` files and fallback to `${REACT_ANDROID_DIR}/cmake-utils/default-app-setup/*.cpp` if none exist. This resolves #48298 ## Changelog: [ANDROID] [FIXED] - Prioritise local OnLoad.cpp, falling back to default-app-setup Pull Request resolved: #48340 Test Plan: - Followed the https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules guide (which was broken > 0.76.1) - Applied the patch to the reproduction repository linked to #47352 to ensure no regression Reviewed By: cipolleschi Differential Revision: D67736012 Pulled By: cortinico fbshipit-source-id: 87f6b8edf1613682585a94e1d1b3e6b4b792e4f5
Configuration menu - View commit details
-
Copy full SHA for 5a64bde - Browse repository at this point
Copy the full SHA 5a64bdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 407c4fb - Browse repository at this point
Copy the full SHA 407c4fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbbeef6 - Browse repository at this point
Copy the full SHA bbbeef6View commit details
Commits on Jan 15, 2025
-
Fix TextMeasureCacheKey Throwing Out Some LayoutConstraints (#48525)
Summary: Pull Request resolved: #48525 Fixes #48249 `TextMeasureCacheKey` hash and equality functions only incorporates the maximum width constraint. I'm guessing this was an attempt at an optimization, but it can lead to incorrect results in pretty trivial cases. E.g. if Yoga knows a definite size of `Text` in one dimension, and measures via `YGMeasureModeExactly`, we can have a minimum size corresponding specific to the style in which the text was laid out. Changelog: [General][Fixed] - Fix TextMeasureCacheKey Throwing Out Some LayoutConstraints Reviewed By: christophpurrer Differential Revision: D67922414 fbshipit-source-id: 0ee0220059fc4e4645b1684c42a0587fe728bedd
Configuration menu - View commit details
-
Copy full SHA for e7db7a7 - Browse repository at this point
Copy the full SHA e7db7a7View commit details -
Paper: TextInput
maxLengthis not working in old arch (#48126)Summary: Fixes #47563 It seems like a regression from #45401, where it was aimed to fix `onChangeText` being called multiple times when changing the text programmatically in an input with the `multiline` prop set as true. This PR reverts that partially, as the `maxLength` check is not being evaluated correctly before setting the text. Not reverting it completely as when removing the second part of the fix, the `onChangeText` gets called multiple times again. ## Changelog: [IOS] [FIXED] - Fixing TextInput `maxLength` not working in old arch Pull Request resolved: #48126 Test Plan: The issue could be reproduced in the rn-tester. See my videos with the before and after the fix. <details> <summary>Before:</summary> https://github.com/user-attachments/assets/86fd67eb-fc14-469a-a5f8-8e83b49f857c </details> <details> <summary>After:</summary> https://github.com/user-attachments/assets/368383b1-c1bd-4e0b-ac44-c78022462fa0 </details> Reviewed By: cortinico Differential Revision: D67025182 Pulled By: cipolleschi fbshipit-source-id: 720c400eef362618106ae434aef421c7529214fe
Configuration menu - View commit details
-
Copy full SHA for 4b3ef3b - Browse repository at this point
Copy the full SHA 4b3ef3bView commit details -
Convert assets-registry to Flow comment syntax (#48458)
Summary: Pull Request resolved: #48458 NOTE: This change is made once and is not guaranteed. **Motivation**: Requiring Flow parsing for `react-native` and its dependencies in user space can involve friction. For the case of `react-native/assets-registry` → `react-native-web`, I believe we should do the pragmatic thing to relax this requirement. - This is a convenience stopgap until #39542 can be stabilised. - This package is tiny and infrequently modified — I believe it's pragmatic/safe to do a one-time conversion, with the above notice and no changelog (i.e. "experimental" for now). Resolves #48349. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D67764460 fbshipit-source-id: 7687fd79c6dea73c234a46e475c1cc745225830b
Configuration menu - View commit details
-
Copy full SHA for 36a0cad - Browse repository at this point
Copy the full SHA 36a0cadView commit details -
Back out "RN: Enable
useInsertionEffectsForAnimations" (#48669)Summary: Pull Request resolved: #48669 Original commit changeset: d09b2f1b7607 Original Phabricator Diff: D65906157 [General] [Fixed] - Disable useInsertionEffectsForAnimations, Fix buttons becoming unresponsive when transform is animated Reviewed By: yungsters Differential Revision: D68152746 fbshipit-source-id: aa0c0aa3243c67c95128a75b40dd6aa1251abbca
Configuration menu - View commit details
-
Copy full SHA for 2013bad - Browse repository at this point
Copy the full SHA 2013badView commit details -
[Local] Fix Flow error with unsupported feature flag metadata
Fixes a Flow error introduced when picking #48669 Changelog: [Internal]
Configuration menu - View commit details
-
Copy full SHA for 2561db8 - Browse repository at this point
Copy the full SHA 2561db8View commit details -
[Local] Update feature flags generated signature
Changelog: [Internal]
Configuration menu - View commit details
-
Copy full SHA for 0ed16b4 - Browse repository at this point
Copy the full SHA 0ed16b4View commit details
Commits on Jan 16, 2025
-
fix hermes param handling in test-e2e-local.js (#48068)
Summary: why: running `yarn test-e2e-local -t "RNTestProject" -p "Android" -h false -c $GITHUB_TOKEN` would actually build the app with Hermes even though it's specified as disabled. This is because of the `if (argv.hermes == null)` condition whose body would not execute. The condition was changed [recently](f322dc7#diff-56f57bf0eac99b0fda1b2938aceb8d9b663db82c07cb405bd53a01c8689710ffR258). Reason for `await` being used: ``` Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ scripts/release-testing/test-e2e-local.js:303:32 Cannot get argv.hermes because property hermes is missing in Promise [1]. [prop-missing] scripts/release-testing/test-e2e-local.js 300│ 'reactNativeArchitectures=arm64-v8a', 301│ 'android/gradle.properties', 302│ ); 303│ const hermesEnabled = (argv).hermes === true; 304│ 305│ // Update gradle properties to set Hermes as false 306│ if (!hermesEnabled) { flow-typed/npm/yargs_v17.x.x.js [1] 80│ argv: Argv | Promise<Argv>; ``` ## Changelog: [INTERNAL] [FIXED] - fix `hermes` param handling in `test-e2e-local.js`
Configuration menu - View commit details
-
Copy full SHA for 5067899 - Browse repository at this point
Copy the full SHA 5067899View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06c8a74 - Browse repository at this point
Copy the full SHA 06c8a74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46cf587 - Browse repository at this point
Copy the full SHA 46cf587View commit details
Commits on Jan 21, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 4eef167 - Browse repository at this point
Copy the full SHA 4eef167View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.77.0-rc.4...v0.77.0