Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react-native
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.73.0-rc.6
Choose a base ref
...
head repository: facebook/react-native
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.73.0-rc.7
Choose a head ref
  • 3 commits
  • 9 files changed
  • 3 contributors

Commits on Dec 1, 2023

  1. Fix android root view group removal during instance re-creation (#41678) 

    Summary:
This is my proposed solution to #41677.

Fixes #41677.

## Changelog:

[ANDROID] [FIXED] - Fix android root view group removal during instance re-creation

Pull Request resolved: #41678

Test Plan:
Both with fabric enabled and disabled (new architecture):

1. Clone repro repo: https://github.com/wschurman/rn-reload-repro
2. Build and run on android (I use android studio)
3. Click reload button, see timestamp doesn't change (indicating that the view is not removed)
4. Apply this PR as a patch.
5. Re-build and run.
6. Click reload button, see view is correctly disposed of and the new view is set.

Reviewed By: cortinico

Differential Revision: D51658524

Pulled By: javache

fbshipit-source-id: d9a026cde677ad1ec113230bc31bd9297bca8bfc
    @wschurman @huntie
    wschurman authored and huntie committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    cd43de6 View commit details
    Browse the repository at this point in the history

  2. Update Podfile.lock

    @huntie
    huntie committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    d97e8e6 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. [0.73.0-rc.7] Bump version numbers

    Distiller committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    bb989e9 View commit details
    Browse the repository at this point in the history
Loading