-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Comparing changes
Open a pull request
base repository: facebook/react-native
base: v0.69.0-rc.4
head repository: facebook/react-native
compare: v0.69.1
- 14 commits
- 33 files changed
- 10 contributors
Commits on May 31, 2022
-
Fix downloading prebuilt hermes from the Github release (#33935)
Summary: This: ```ruby source[:http] = `https://github.com/facebook/react-native/releases/download/v#{version}/hermes-runtime-darwin-v#{version}.tar.gz` ``` currently fails with the following error: ``` [!] Failed to load 'hermes-engine' podspec: [!] Invalid `hermes-engine.podspec` file: No such file or directory - https://github.com/facebook/react-native/releases/download/v0.69.0-rc.4/hermes-runtime-darwin-v0.69.0-rc.4.tar.gz. ``` For some reasons, the string with backticks is treated differently than with double quotes since this works: ```ruby source[:http] = "https://github.com/facebook/react-native/releases/download/v#{version}/hermes-runtime-darwin-v#{version}.tar.gz" ``` ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] - Fix downloading prebuilt hermes from the Github release Pull Request resolved: #33935 Test Plan: - `npx react-native init RN069RC4 --version 0.69.0-rc.4` - in the created project, run `pod install` with hermes enabled - run `git init && git add . && git commit -m "Initial commit" && git remote add origin https://github.com/fortmarek/some-fake-repository` (this is necessary due to an unrelated bug in the RC4) - observe error - update `node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec` with the change from this commit - run `pod install` - 🎉 Reviewed By: dmitryrykun Differential Revision: D36775047 Pulled By: cortinico fbshipit-source-id: 3772adca32fe9898cde33c187d19b7b181af3677
Configuration menu - View commit details
-
Copy full SHA for 88fa872 - Browse repository at this point
Copy the full SHA 88fa872View commit details -
Configuration menu - View commit details
-
Copy full SHA for f50936b - Browse repository at this point
Copy the full SHA f50936bView commit details -
[0.69.0-rc.5] Bump version numbers
Distiller committedMay 31, 2022 Configuration menu - View commit details
-
Copy full SHA for 6d200c3 - Browse repository at this point
Copy the full SHA 6d200c3View commit details
Commits on Jun 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7262acc - Browse repository at this point
Copy the full SHA 7262accView commit details -
Make sure sdks/.hermesversion is included inside the NPM package.
Summary: The sdks/.hermesversion file should be included inside the React Native NPM package. While this file is available on the release branch, so it's effectively used during artifact preparation, the file should also be included inside the react-native NPM package. This commit addresses it. Changelog: [Internal] - Make sure sdks/.hermesversion is included inside the NPM package Reviewed By: dmitryrykun Differential Revision: D36785480 fbshipit-source-id: 1152de77818e92814b402a57ca5a05c235747eac
Configuration menu - View commit details
-
Copy full SHA for e8af5b8 - Browse repository at this point
Copy the full SHA e8af5b8View commit details -
[0.69.0-rc.6] Bump version numbers
Distiller committedJun 1, 2022 Configuration menu - View commit details
-
Copy full SHA for e68aa6a - Browse repository at this point
Copy the full SHA e68aa6aView commit details
Commits on Jun 22, 2022
-
Distiller authored and Distiller committed
Jun 22, 2022 Configuration menu - View commit details
-
Copy full SHA for 74a08a3 - Browse repository at this point
Copy the full SHA 74a08a3View commit details
Commits on Jun 29, 2022
-
Use monotonic clock for performance.now() (#33983)
Summary: In #32695, the `Performance.now()` implementation changed to use unix epoch timestamps instead of a monotonic clock. This is problematic, because it means that performance measurements get skewed if the device clock changes between two measurements. With this change, the clock is now monotonic (and the implementation stays consistent between platforms). More details and repro steps can be found in [this issue](#33977) Closes #33977 ## Changelog [General] [Fixed] - Use monotonic clock for performance.now() Pull Request resolved: #33983 Test Plan: Run on iOS and Android: ``` const now = global.performance.now() console.log(`${Platform.OS}: ${now}`) ``` Reviewed By: JoshuaGross, cipolleschi Differential Revision: D37066999 Pulled By: dmitryrykun fbshipit-source-id: 298547bf39faea1b025c17ff2d2e1a03f929865b
Configuration menu - View commit details
-
Copy full SHA for dc334a2 - Browse repository at this point
Copy the full SHA dc334a2View commit details -
Make all headers public and add #ifdef __cplusplus (#1150)
Summary: This change is mostly needed to support the new react-native architecture with Swift. Some private yoga headers end up being included in the swift build and result in compilation failure since swift cannot compile c++ modules. See #33381. The most reliable fix is to include all headers as public headers, and add `#ifdef __cplusplus` to those that include c++. This is already what we do for other headers, this applies this to all headers. Tested in the YogaKitSample, and also in a react-native app. Changelog: [iOS] [Changed] - Make all Yoga headers public and add #ifdef __cplusplus X-link: facebook/yoga#1150 Reviewed By: dmitryrykun Differential Revision: D36966687 Pulled By: cortinico fbshipit-source-id: a34a54d56df43ab4934715070bab8e790b9abd39
Configuration menu - View commit details
-
Copy full SHA for aa068e0 - Browse repository at this point
Copy the full SHA aa068e0View commit details -
revert #33381 changes (#33973)
Summary: facebook/yoga#1150 is better than the tricky #33381 and fix the build error on react-native 0.69 with swift clang module. as facebook/yoga#1150 is landed as 43f831b, i'm reverting the previous change, only leaving the necessary react_native_pods.rb change. ## Changelog [iOS] [Changed] - Better fix for yoga + swift clang module build error Pull Request resolved: #33973 Test Plan: ci passed Reviewed By: cortinico, cipolleschi Differential Revision: D36998007 Pulled By: dmitryrykun fbshipit-source-id: fa11bd950e2a1be6396f286086f4e7941ad2ff5b
Configuration menu - View commit details
-
Copy full SHA for 9d3ce32 - Browse repository at this point
Copy the full SHA 9d3ce32View commit details -
Fix broken use_frameworks from React-bridging (#34011)
Summary: `use_frameworks!` is broken again in react-native 0.69 because React-bridging. in the `use_frameworks!` mode, header structures are flattened, so `#include <react/bridging/CallbackWrapper.h>` is not reachable to the header. to somehow workaround the issue without touch React-bridging imports, the pr do these things: - use `header_mappings_dir` to keep `react/bridging` header structure - because the header structure is not default framework header structure, explicitly `HEADER_SEARCH_PATHS` is necessary. - forward declare `CallbackWrapper` and use it internally in ReactCommon. so that we don't need to add `HEADER_SEARCH_PATHS` for React-bridging to every pods depending on `ReactCommon/turbomodule/core`, e.g. React-RCTSettings.podspec. [iOS] [Fixed] - Fix use_frameworks! for 0.69 Pull Request resolved: #34011 Test Plan: ```sh $ npx react-native init RN069 --version next $ yarn ios ``` Reviewed By: cortinico, cipolleschi Differential Revision: D37169699 Pulled By: dmitryrykun fbshipit-source-id: 309c55f1c611a2fc3902a83e8af814daaf2af6a0
Configuration menu - View commit details
-
Copy full SHA for 9e591ac - Browse repository at this point
Copy the full SHA 9e591acView commit details -
Fix RCT-Folly build error when use_frameworks! and hermes are both en…
…abled (#34030) Summary: This PR is fixing the build errors on iOS when `use_frameworks!` and `:hermes_enabled` are both enabled. There are two errors: - fmt/compile.h include not found: This PR adds fmt in header search paths. - undefined symbols `_jump_fcontext` and `_make_fcontext` from boost. the two symbols are actually not be unused. because to generate the shared library in dynamic framework mode, LTO (Link-Time-Optimization) is not as powerful as generating a single executable. ## Changelog [iOS] [Fixed] - Fix RCT-Folly build error when use_frameworks! and hermes are both enabled Pull Request resolved: #34030 Test Plan: - CI passed - ``` $ npx react-native init RN069 --version next # edit RN069/ios/Podfile to enable use_frameworks! and hermes_enabled # patch node_modules/react-native from both #34011 and this prs' patch $ pod install $ yarn ios ``` Reviewed By: cortinico Differential Revision: D37284084 Pulled By: dmitryrykun fbshipit-source-id: 923fa03d7844d1d227880919c8b2c8614c848d59
Configuration menu - View commit details
-
Copy full SHA for 050924a - Browse repository at this point
Copy the full SHA 050924aView commit details -
fix(build): fixes React-RCTText build with RN 0.69.0 (#34064)
Summary: Fixes iOS build for React-RCTText with RN 0.69.0, fixes #33976 PR contains changes from #33976 (comment) PoC repo: https://github.com/ph4r05/poc-rn-34064 Related issues: - expo/expo#16283 - #33815 - #33976 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Fixed] - Fix build for React-RCTText Pull Request resolved: #34064 Reviewed By: cortinico Differential Revision: D37420163 Pulled By: cipolleschi fbshipit-source-id: 68a831bce9f449348d13e040a1ba12726a66667d
Configuration menu - View commit details
-
Copy full SHA for 802d324 - Browse repository at this point
Copy the full SHA 802d324View commit details -
Distiller authored and Distiller committed
Jun 29, 2022 Configuration menu - View commit details
-
Copy full SHA for 587eb4e - Browse repository at this point
Copy the full SHA 587eb4eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.69.0-rc.4...v0.69.1