Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react-native
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.66.2
Choose a base ref
...
head repository: facebook/react-native
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.66.3
Choose a head ref
  • 7 commits
  • 19 files changed
  • 4 contributors

Commits on Nov 10, 2021

  1. bump-oss-version: Add -v / --to-version argument and use it when bump… 

    …ing nightly releases (now at 20:00 UTC)

Summary:
Add a new -v or --to-version argument to the bump-oss-version script.

When the bump-oss-version script runs, it will use the version string that is passed in, instead of trying to infer it from the current commit. This fixes a bug in the last nightly release where the bump script used a different version string than what the publish script expected.

Nightlies now run at 20:00 hours UTC.

Changelog: [Internal]

Reviewed By: fkgozali, TheSavior

Differential Revision: D31261829

fbshipit-source-id: a9341f93c3c7bf0379aa3c5e7f345182df70f846
    @hramos
    hramos authored and Luna Wei committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    d08397a View commit details
    Browse the repository at this point in the history

  2. Extract version parsing from release script 

    Summary: Changelog: [Internal] - extract logic for parsing version in bump-oss-version and add tests

Reviewed By: cortinico

Differential Revision: D32196238

fbshipit-source-id: 6ea7af3d282eea1d876118f056bca94a151e6182
    Luna Wei committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    8a67aaa View commit details
    Browse the repository at this point in the history

  3. Clean up publish-npm.js and use parseVersion 

    Summary:
Changelog: [Internal] Remove unnecessary logic and new parseVersions function

Changes:
* Remove `tagsForVersions` which in the past got all the tags for the `currentCommit` to figure out which one we're releasing to. I believe this is redundant because the CircleCI envvar `CIRCLE_TAG` should already have the version that we're releasing -- this is set in `bump-oss-version`. Note: this will only be set for full-on releases, (re: not nightly or commitly)
* Re-arrange some logic to group where we set `releaseVersion` and separate where we call `bump-oss-version` script for dryRun (commitly) && nightly builds

Reviewed By: hramos

Differential Revision: D32196237

fbshipit-source-id: 10f21f71bad1ea0496c5eb9094271cc4454a2544
    Luna Wei committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    85f1450 View commit details
    Browse the repository at this point in the history

  4. Fix npm latest tag issue when releasing patches (#32543) 

    Summary:
Pull Request resolved: #32543

Changelog: [Internal] Fix npm `latest` tag issue that occurs when we release a patch on an older minor version

Context:
* There are two types of tags, git and npm, they are unrelated.

* When we publish a stable release, we set the git tag `latest`. This logic is faulty when we release a patch to an older version.

* When publishing a package to npm, if you don't provide an explicit tag, the `latest` tag will be applied -- at least that's how I've understood the [docs here](https://docs.npmjs.com/cli/v7/commands/npm-dist-tag#description). This again is faulty logic when we release a patch to an older version.

* npm and git's `latest` tag should always point to our most recent stable version

This change:
* Introduces a `--latest` flag for `bump-oss-script` that will indicate that the release we're running (either a stable or pre-release) should really be considered "latest"
* If the version is not a pre-release and the `--latest` flag is set, we will set the git `latest` tag
* Later, in the circleCI job that we use to publish the npm package, we will see if the current commit is git-tagged as `latest`. If it is, then we'll explicitly tell npm to use `latest` tag but most importantly, if it's not, we'll set a tag of the form `{major}.{minor}-stable`.
* This type of tag (ex. `0.66-stable`) is new and the intention is that it will always point to latest of that minor version.

Reviewed By: hramos

Differential Revision: D32196239

fbshipit-source-id: 4c881851eebcad8585732ff0c07322413ac46ce5
    Luna Wei committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    f35369e View commit details
    Browse the repository at this point in the history

  5. Revert changes in RN preprocessor 

    Summary: Changelog: [General][Fixed] Revert changes in Jest preprocessor to fix tests in external projects

Reviewed By: yungsters

Differential Revision: D32250044

fbshipit-source-id: 0ed4c9f7bcfa82349b5c2ec7af2ccda970bbb0ef
    @rubennorte
    rubennorte authored and Luna Wei committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    142090a View commit details
    Browse the repository at this point in the history

  6. RN: Rename Keyboard.remove{Event =>}Listener 

    Summary:
Renames `Keyboard.removeEventListener` to `Keyboard.removeListener`.

When I implemented the compatibility layer in {D26589441 (035718b)}, I accidentally used the wrong name. Since `Keyboard.removeEventListener` was always deprecated, this removes it completely.

Changelog:
[General][Changed] - Rename deprecated `Keyboard.removeEventListener` to `Keyboard.removeListener`.

Reviewed By: lunaleaps

Differential Revision: D32282743

fbshipit-source-id: 309382af3269f85f781d38367d115a2ce3690efb
    @yungsters
    yungsters authored and Luna Wei committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    0981564 View commit details
    Browse the repository at this point in the history

  7. [0.66.3] Bump version numbers

    Luna Wei committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    3b5e446 View commit details
    Browse the repository at this point in the history
Loading