Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react-native
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.65.1
Choose a base ref
...
head repository: facebook/react-native
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.65.3
Choose a head ref
  • 5 commits
  • 16 files changed
  • 4 contributors

Commits on Nov 4, 2021

  1. Addressing various issues with the Appearance API (#28823) (#29106)

    Summary:
    This PR fixes a few issues with the Appearance API (as noted here #28823).
    
    1. For the Appearance API to work correctly on Android you need to call `AppearanceModule.onConfigurationChanged` when the current Activity goes through a configuration change. This was being called in the RNTester app but not in `ReactActivity` so it meant the Appearance API wouldn't work for Android in newly generated RN projects (or ones upgraded to the latest version of RN).
    
    2. The Appearance API wasn't working correctly for brownfield scenarios on Android. It's possible to force an app light or dark natively on Android by calling `AppCompatDelegate.setDefaultNightMode()`. The Appearance API wasn't picking up changes from this function because it was using the Application context instead of the current Activity context.
    
    3. The Appearance API wasn't working correctly for brownfield scenarios on iOS. Just like on Android its possible to force an app light or dark natively by setting `window.overrideUserInterfaceStyle`. The Appearance API didn't work with this override because we were overwriting `_currentColorScheme` back to default as soon as we set it.
    
    ## Changelog
    
    <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
    https://github.com/facebook/react-native/wiki/Changelog
    -->
    
    ### Fixed
    
    #28823
    
    * [Android] [Fixed] - Appearance API now works on Android
    * [Android] [Fixed] - Appearance API now works correctly when calling `AppCompatDelegate.setDefaultNightMode()`
    * [iOS] [Fixed] - Appearance API now works correctly when setting `window.overrideUserInterfaceStyle`
    
    Pull Request resolved: #29106
    
    Test Plan: Ran RNTester on iOS and Android and verified the Appearance examples still worked [correctly.](url)
    
    Reviewed By: hramos
    
    Differential Revision: D31284331
    
    Pulled By: sota000
    
    fbshipit-source-id: 45bbe33983e506eb177d596d33ddf15f846708fd
    mrbrentkelly authored and Luna Wei committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    b4b2853 View commit details
    Browse the repository at this point in the history
  2. [0.65.2] Bump version numbers

    Luna Wei committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    7eff4b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2022

  1. Configuration menu
    Copy the full SHA
    9548eae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d5411b3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2642fe1 View commit details
    Browse the repository at this point in the history
Loading