Merge pull request arskom#557 from Osso/lxml-warning

plq · web-flow · commit 436f3d36938e · 2018-03-13T09:41:24.000+02:00
Lxml warnings
diff --git a/spyne/protocol/soap/soap12.py b/spyne/protocol/soap/soap12.py
@@ -73,7 +73,7 @@ def generate_faultcode(self, element):
         faultcode = []
         faultcode.append(element.find('soap:Code/soap:Value', namespaces=nsmap).text)
         subcode = element.find('soap:Code/soap:Subcode', namespaces=nsmap)
-        while subcode:
+        while subcode is not None:
             faultcode.append(subcode.find('soap:Value', namespaces=nsmap).text)
             subcode = subcode.find('soap:Subcode', namespaces=nsmap)
 
@@ -95,7 +95,7 @@ def _fault_to_parent_impl(self, ctx, cls, inst, parent, ns, subelts, **_):
         tag_name = "{%s}Fault" % self.ns_soap_env
 
         if isinstance(inst.faultcode, string_types):
-            value, faultcodes  = self.gen_fault_codes(inst.faultcode)
+            value, faultcodes = self.gen_fault_codes(inst.faultcode)
 
             code = E("{%s}Code" % self.ns_soap_env)
             code.append(E("{%s}Value" % self.ns_soap_env, value))
@@ -135,17 +135,17 @@ def schema_validation_error_to_parent(self, ctx, cls, inst, parent, ns, **_):
         return self._fault_to_parent_impl(ctx, cls, inst, parent, ns, subelts)
 
     def fault_from_element(self, ctx, cls, element):
-        nsmap  = element.nsmap
+        nsmap = element.nsmap
 
         code = self.generate_faultcode(element)
         reason = element.find("soap:Reason/soap:Text", namespaces=nsmap).text.strip()
         role = element.find("soap:Role", namespaces=nsmap)
         node = element.find("soap:Node", namespaces=nsmap)
         detail = element.find("soap:Detail", namespaces=nsmap)
         faultactor = ''
-        if role:
+        if role is not None:
             faultactor += role.text.strip()
-        if node:
+        if node is not None:
             faultactor += node.text.strip()
         return cls(faultcode=code, faultstring=reason,
-                   faultactor = faultactor, detail=detail)
+                   faultactor=faultactor, detail=detail)
