Skip to content

refactor(cli): add fallback with husky git params to deprecation handling#498

Merged
marionebl merged 2 commits intomasterfrom
bycedric-cli-gitparams-rename
Nov 30, 2018
Merged

refactor(cli): add fallback with husky git params to deprecation handling#498
marionebl merged 2 commits intomasterfrom
bycedric-cli-gitparams-rename

Conversation

@byCedric
Copy link
Member

@byCedric byCedric commented Nov 26, 2018 •
edited
Loading

Description

This adds HUSKY_GIT_PARAMS fallback to the existing GIT_PARAMS deprecation handling, as described in their docs.

Note, I've created two solutions for this problem. This is one, and the other one is to remove (and later reimplement). Please pick one, I'll close the other.

Edit, I prefer this one since it's now backward compatible.

Motivation and Context

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This was referenced Nov 26, 2018
Closed
Merged
@byCedric byCedric force-pushed the bycedric-cli-gitparams-rename branch from 580eb4b to 2f6182e Compare November 27, 2018 22:12
@byCedric
Copy link
Member Author

byCedric commented Nov 27, 2018

There we go! Now it shouldn't be backward incompatible and doesn't require a major update 😄

@byCedric byCedric force-pushed the bycedric-cli-gitparams-rename branch from 2f6182e to d231b4a Compare November 27, 2018 22:21
@byCedric
Copy link
Member Author

byCedric commented Nov 27, 2018

Ok, now it works fine I think. If GIT_PARAMS is used, but not defined, it falls back to the HUSKY_GIT_PARAMS check. If that is also not defined, the error is thrown. 😄

@byCedric
Copy link
Member Author

byCedric commented Nov 27, 2018

I prefer to use this one over #499 because it's backward compatible.

@byCedric byCedric changed the title refactor(cli): rename old husky git params to husky prefix refactor(cli): add fallback with husky git params to deprecation handling Nov 27, 2018
@escapedcat
Copy link
Member

escapedcat commented Nov 28, 2018

If this works fine I would also use this over #499 👍

@marionebl
Copy link
Contributor

marionebl commented Nov 30, 2018

OK, let's do this! :)

@marionebl marionebl merged commit 5a34b8c into master Nov 30, 2018
@marionebl marionebl deleted the bycedric-cli-gitparams-rename branch November 30, 2018 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@byCedric @escapedcat @marionebl