fix: footer parser does not escape special chars for regex #4560#4634
fix: footer parser does not escape special chars for regex #4560#4634escapedcat merged 2 commits intomasterfrom
Conversation
Review Summary by QodoAdd @types/conventional-commits-parser to fix TypeScript TS7016 error
WalkthroughsDescription• Add @types/conventional-commits-parser to resolve TS7016 error • Dependency added to both @commitlint/cli and @commitlint/rules packages Diagramflowchart LR
A["TS7016 Error\n(missing type declarations)"] -- "add @types/conventional-commits-parser ^5.0.2" --> B["@commitlint/cli\npackage.json"]
A -- "add @types/conventional-commits-parser ^5.0.2" --> C["@commitlint/rules\npackage.json"]
File Changes1. @commitlint/cli/package.json
|
Code Review by Qodo
1. Fragile hoisted type dependency
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Pull request overview
Updates the monorepo’s dependency set—centered around upgrading conventional-commits-parser—and adds TypeScript typings to address missing type definitions during TS compilation (TS7016), in the context of issue #4560.
Changes:
- Bump
conventional-commits-parserto^6.3.0across commitlint packages and update related conventional-changelog presets. - Add
@types/conventional-commits-parserto relevant workspaces to satisfy TypeScript type resolution. - Refresh various toolchain deps (ESLint, SWC, Vue, cosmiconfig) and regenerate
yarn.lock.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Lockfile regeneration reflecting updated versions and newly added transitive deps (e.g., @simple-libs/stream-utils). |
package.json |
Tooling dependency bumps (ESLint, SWC, TS ESLint) and Vue update; removes @eslint/js. |
@commitlint/types/package.json |
Upgrades conventional-commits-parser to ^6.3.0 for shared types package. |
@commitlint/rules/package.json |
Adds @types/conventional-commits-parser and bumps parser + changelog-angular preset. |
@commitlint/parse/package.json |
Bumps parser + changelog-angular preset used by the core parsing layer. |
@commitlint/load/package.json |
Updates cosmiconfig to ^9.0.1. |
@commitlint/load/fixtures/parser-preset-conventionalcommits/package.json |
Bumps conventional-changelog-conventionalcommits fixture version. |
@commitlint/load/fixtures/parser-preset-conventional-without-factory/package.json |
Bumps conventional-changelog-conventionalcommits fixture version. |
@commitlint/config-conventional/package.json |
Bumps conventional-changelog-conventionalcommits. |
@commitlint/cli/package.json |
Adds @types/conventional-commits-parser to support TS type imports in CLI sources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
df86dab to
191c8c2
Compare
191c8c2 to
e312f08
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
17e8c80 to
46be149
Compare
Fixes: #4560