Skip to content

Should the CSV field delimiter be localised? #1020

@willpower232

Description

@willpower232

As per the original work in #196 the CSV field delimiter defaults to a semicolon which I now know is the default in Brazil.

However I'm surprised that it isn't a comma and nothing I have works with the semicolon so I have to change it every time.

If the delimiter was included as a semicolon in src/renderer/i18n/pt-BR.ts and then as a comma in src/renderer/i18n/en-US.ts then would it serve both purposes or is that too much of a backwards compatibility break?

Affected line of code is here
https://github.com/antares-sql/antares/blame/954b455f612d170742c1a1065276132f2cc115ea/src/renderer/components/WorkspaceTabQueryTable.vue#L866

Thanks for your time and efforts.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions