Skip to content

Commit 418de19

Browse files
authored
[Documentation:Developer] Add PR Template Warning (#12342)
### Why is this Change Important & Necessary? Recently, we have been getting an influx of pull requests that do not comply with Submitty's conventions. This leads to a drawn out review process as we have to wait for contributors to update their PR before we can even review it. ### What is the New Behavior? Added the following to the top of our pull request description template: ``` <!-- ** Please remove all comment blocks in the description before submitting this PR. ** --> <!-- NOTE: Please ensure your title and description align with Submitty conventions (see https://submitty.org/developer/getting_started/make_a_pull_request for more details). Each title has a prefix, and a limit of 40 chars. A description template has been provided and must be completed in full. Please also ensure that all CI tests are passing. Pull requests that do not meet these requirements are ineligible for review and may be closed. --> ``` ### Automated Testing & Documentation We should add more documentation tests that check if comments have been deleted, and verify that the template headers are within the description. ### What steps should a reviewer take to reproduce or test the bug or new feature? Is this change sufficient? Should I add/remove anything?
1 parent 81c3909 commit 418de19

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
<!-- ** Please remove all comment blocks in the description before submitting this PR. ** -->
2+
3+
<!-- NOTE: Please ensure your title and description align with Submitty conventions (see
4+
https://submitty.org/developer/getting_started/make_a_pull_request for more details).
5+
Each title has a prefix, and a limit of 40 chars. A description template has been
6+
provided and must be completed in full. Please also ensure that all CI tests
7+
are passing. Pull requests that do not meet these requirements are ineligible for
8+
review and may be closed. -->
9+
110
### Why is this Change Important & Necessary?
211
<!-- Include any GitHub issue that is fixed/closed using "Fixes #<number>" or "Closes #<number>" syntax.
312
Alternately write "Partially addresses #<number>" or "Related to #<number>" as appropriate. -->

0 commit comments

Comments
 (0)